feat(intro): Add short Intro Logo for The Super Hackers team by xezon · Pull Request #2267 · TheSuperHackers/GeneralsGameCode

xezon · 2026-02-07T13:55:31Z

Merge with Rebase

Relevant friend change: tweak(commandline): Skip intro logo with -quickstart and enable -nologo, -noShellAnim in Release builds #2266

This change has 5 commits:

Move intro related code to new file and class
Simplify the intro state machine to make it easier to modify and extend
Remove the non functional copyright string and simplify the EA logo movie code. This also shortens the effective EA logo duration by 3 to 5 seconds.
Remove the superfluous legal page from intro sequence, which would have lasted 4 seconds after Sizzle video but was practically never visible except if the mem pass would have failed (relevant for 2000 era computers). I think the condition was actually meant to be the inverse...
Add new intro screen for The Super Hacker team

Old Intro Sequence

EA Logo, 3 seconds, non skippable
Black Screen, 3-5 seconds (*1), non skippable
Sizzle Video, skippable
Legal Page, 4 seconds, practically never shown
Shell Map load screen

(*1) I did not measure how long the black screen was. According to code somewhere between 3 to 5 seconds.

New Intro Sequence

EA Logo, 3 seconds, non skippable
Black Screen, 800 milliseconds, non skippable
The Super Hackers Logo, 3 seconds, non skippable
Black Screen, 1 second, non skippable
Sizzle Video, skippable
Shell Map load screen

TODO

Replicate in Generals
Add pull id to commit titles
Verify each commit compiles individually

greptile-apps · 2026-02-07T13:57:27Z

Greptile Summary

This PR replaces the old startup intro flow with a dedicated intro sequence.

Adds the EA, Super Hackers, and sizzle states.
Moves intro timing and logo drawing into Intro.
Removes the legacy logo hold and legal-page flow.
Connects the new intro renderer to the W3D display path.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameClient/Intro.cpp	Adds the intro state machine, logo screen, timing, and fade behavior.
GeneralsMD/Code/GameEngine/Source/GameClient/GameClient.cpp	Creates, updates, renders, completes, and destroys the intro controller.
GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp	Calls the GameClient draw hook from the W3D render sequence.

_{Reviews (15): Last reviewed commit: "fixup! refactor(intro): Move intro relat..." | Re-trigger Greptile}

greptile-apps

_{9 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-07T13:57:38Z

Additional Comments (1)

GeneralsMD/Code/GameEngine/Source/GameClient/GameClient.cpp
Intro can block startup

GameClient::update() only shows the shell (TheShell->showShellMap/showShell) after m_intro->isDone(). With the new Intro implementation, if the global flags disable both intro and sizzle (m_playIntro==false and m_playSizzle==false) and m_afterIntro is not pre-set, Intro never reaches Done (see IntroState_Start handling), so the game can get stuck in the intro phase and never show the shell. This previously worked because GameEngine::init() forced m_afterIntro = TRUE when m_playIntro was false.

Fix by making Intro immediately become done when there are no enabled states, or by preserving the old m_afterIntro initialization behavior.

Prompt To Fix With AI

This is a comment left during a code review.
Path: GeneralsMD/Code/GameEngine/Source/GameClient/GameClient.cpp
Line: 514:531

Comment:
**Intro can block startup**

`GameClient::update()` only shows the shell (`TheShell->showShellMap/showShell`) after `m_intro->isDone()`. With the new `Intro` implementation, if the global flags disable both intro and sizzle (`m_playIntro==false` and `m_playSizzle==false`) and `m_afterIntro` is not pre-set, `Intro` never reaches `Done` (see `IntroState_Start` handling), so the game can get stuck in the intro phase and never show the shell. This previously worked because `GameEngine::init()` forced `m_afterIntro = TRUE` when `m_playIntro` was false.

Fix by making `Intro` immediately become done when there are no enabled states, or by preserving the old `m_afterIntro` initialization behavior.

How can I resolve this? If you propose a fix, please make it concise.

greptile-apps

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

helmutbuhler · 2026-02-07T17:16:49Z

Wouldn't it be more appropriate to show the Superhackers stuff in the credits menu? As is this would imply that the whole game is made by us. I don't think it would be fair to show our names more prominently than the original developers.

xezon · 2026-02-07T17:45:57Z

Wouldn't it be more appropriate to show the Superhackers stuff in the credits menu? As is this would imply that the whole game is made by us. I don't think it would be fair to show our names more prominently than the original developers.

Maybe remove all user names from this Intro and just show the Team name + url?

We can also clarify "Edited by ..."

helmutbuhler · 2026-02-07T17:58:51Z

Wouldn't it be more appropriate to show the Superhackers stuff in the credits menu? As is this would imply that the whole game is made by us. I don't think it would be fair to show our names more prominently than the original developers.

Maybe remove all user names from this Intro and just show the Team name + url?

We can also clarify "Edited by ..."

I wouldn't add anything to the intro. I don't think it's necessary to remind the player every time the game starts who made the patch. Maybe just add a tiny note on the shellmap screen below the gamename "patched by Superhackers" or something like that.

It's nice though that the 3-5 seconds black screen is removed here!

Caball009 · 2026-02-08T06:11:36Z

I didn't even know what the 'black screen' was when I saw this PR, because I have renamed the files for the EA logo and sizzle and I don't see it. This makes the game launch faster, and saves me 5+ seconds every time I launch the game. I strongly dislike changing anything that would unnecessarily increase the launch time for me as developer. I'm ok with it if I can skip it with some command line.

That said, I like the new intro.

LegionnaireG · 2026-02-08T16:21:37Z

I don't think people will understand what it means if the intro screen is this plain. On the intro, maybe add 3 to 5 sentences with the key achievements of TheSuperHackers. Maybe something like:

  We've patched up the game to bring you:
  - Improving game stability
  - Unlocked 60+ FPS for single player
  - Significant reduction in mismatches for multiplayer
  - Higher graphics preset
  - Vulnerability fixes

tintinhamans · 2026-02-08T16:39:44Z

I don't think people will understand what it means if the intro screen is this plain. On the intro, maybe add 3 to 5 sentences with the key achievements of TheSuperHackers. Maybe something like:
  We've patched up the game to bring you:
  - Improving game stability
  - Unlocked 60+ FPS for single player
  - Significant reduction in mismatches for multiplayer
  - Higher graphics preset
  - Vulnerability fixes

I feel like adding too much text won't really be very useful given the fact that it's only shown for 3 seconds.

xezon · 2026-02-08T21:53:08Z

I feel like adding too much text won't really be very useful given the fact that it's only shown for 3 seconds.

I agree with this sentiment.

What we can add is a "Improved by" on top, to clarify that this Author has improved the game. This is very simple and broad.

xezon · 2026-02-09T11:31:16Z

When this is merged I will make a follow up to skip the entire intro sequence with a single ESC press. This will alleviate any waiting pains for impatient users.

xezon · 2026-02-11T19:48:35Z

Improvements applied according to feedbacks:

Removed all individual contributor names (to be shown in Credits Menu instead)
Replaced github url with domain name
Added pretext to clarify that we did not built the game, but improved it

greptile-apps

_{12 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-11T19:50:19Z

Additional Comments (1)

GeneralsMD/Code/GameEngine/Source/GameClient/GameClient.cpp
Missing cleanup of m_intro in destructor - potential memory leak if GameClient is destroyed before intro completes.

	delete m_intro;
	m_intro = nullptr;

Prompt To Fix With AI

This is a comment left during a code review.
Path: GeneralsMD/Code/GameEngine/Source/GameClient/GameClient.cpp
Line: 119:119

Comment:
Missing cleanup of `m_intro` in destructor - potential memory leak if `GameClient` is destroyed before intro completes.

```suggestion
	delete m_intro;
	m_intro = nullptr;
```

How can I resolve this? If you propose a fix, please make it concise.

greptile-apps

_{12 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

xezon · 2026-02-11T22:48:18Z

Maybe text can be made a bit bigger.

fbraz3 · 2026-02-13T02:51:22Z

A suggestion: the credits screen would display all contributors names.

Something like:

# TheSuperHackers Team

Name 1 - Role
Name 2 - Role
Name 3 - Role
......

# Individual Contributors

Name 4 - 100 commits
Name 5 - 95 commits
.....

# EA games
......
......
......

The git summary command from Git Extras can be used to generate the individual contributors report and add it dinamically on build time.
https://github.com/tj/git-extras/blob/main/Commands.md#git-summary

xezon · 2026-05-22T08:09:40Z

Needs rebase and review.

githubawn · 2026-05-26T03:22:38Z

I don't think ASCII is worth the trouble even though it looks pretty cool.

Maybe something like this:

// logo.h - Generated from logo.png using a tool like xxd or a python script
const unsigned char LOGO_IMAGE_BYTES[] = {
    0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00, 0x00, 0x00, 0x0d,
    // ... thousands of bytes ...
    0x00, 0x00, 0x00, 0x00, 0x49, 0x45, 0x4e, 0x44, 0xae, 0x42, 0x60, 0x82
};
const unsigned int LOGO_IMAGE_BYTES_LEN = sizeof(LOGO_IMAGE_BYTES);

Embedding an image into the exe is also possible. Some IDE's have resource editors.

// resource.rc
IDB_LOGO_IMAGE    RCDATA    "logo.png" //

HRSRC hResource = FindResource(NULL, MAKEINTRESOURCE(IDB_LOGO_IMAGE), RT_RCDATA);
HGLOBAL hMemory = LoadResource(NULL, hResource);
DWORD imageSize = SizeofResource(NULL, hResource);
void* pImageData = LockResource(hMemory);
// pImageData now points to the PNG file in memory!

Also haven't seen a "www." in a while, might be cleaner to just show thesuperhackers.org.
Maybe also add a Super Hacker Unit soundbite (either random or preselected). Which could dictate the length how long the text is shown on screen. Just for the fact that C&C games do not have dead air.
Maybe consider changing "Game improved by" to something like "Kept alive with love by" or "Lovingly maintained by".

The code itself looks good.

bobtista · 2026-05-26T04:36:33Z

+
+	if (TheGlobalData->m_playSizzle)
+	{
+		if (TheGlobalData->m_playIntro)


nit: style, always use braces, several times in this file: line 55, 67, 102, 219, 274

For small conditions it is generally ok when it reads ok.

xezon · 2026-05-26T04:36:44Z

Oh wow why does the ASCII text fall apart like this?

bobtista · 2026-05-26T04:42:37Z

I left some nits, and it needs another rebase, but it looks good to me. I think ESC should work to skip, and/or a -quickstart arg would be nice.

bobtista · 2026-05-26T05:08:41Z

I don't think ASCII is worth the trouble even though it looks pretty cool.

Maybe something like this:
// logo.h - Generated from logo.png using a tool like xxd or a python script
const unsigned char LOGO_IMAGE_BYTES[] = {
    0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00, 0x00, 0x00, 0x0d,
    // ... thousands of bytes ...
    0x00, 0x00, 0x00, 0x00, 0x49, 0x45, 0x4e, 0x44, 0xae, 0x42, 0x60, 0x82
};
const unsigned int LOGO_IMAGE_BYTES_LEN = sizeof(LOGO_IMAGE_BYTES);
Embedding an image into the exe is also possible. Some IDE's have resource editors.
// resource.rc
IDB_LOGO_IMAGE    RCDATA    "logo.png" //
HRSRC hResource = FindResource(NULL, MAKEINTRESOURCE(IDB_LOGO_IMAGE), RT_RCDATA);
HGLOBAL hMemory = LoadResource(NULL, hResource);
DWORD imageSize = SizeofResource(NULL, hResource);
void* pImageData = LockResource(hMemory);
// pImageData now points to the PNG file in memory!
Also haven't seen a "www." in a while, might be cleaner to just show thesuperhackers.org.

Maybe also add a Super Hacker Unit soundbite (either random or preselected). Which could dictate the length how long the text is shown on screen. Just for the fact that C&C games do not have dead air.

Maybe consider changing "Game improved by" to something like "Kept alive with love by" or "Lovingly maintained by".

The code itself looks good.

Oof that's no good. I'm in favor of using an image instead of ascii. If we need to troubleshoot the ascii, claude says "pick a much larger sizeY (so GDI's full-block glyph actually fills its cell), guarantee the font is installed (or use one shipped with the game), and stop the setWordWrap call from running every draw" - but I still think an image is easier and safer

xezon · 2026-05-31T10:35:17Z

I don't think ASCII is worth the trouble even though it looks pretty cool.

I changed the font. Please try again. A mono font should work. That said, the previous font was supposed to be mono, but maybe it is not on all systems.

Also haven't seen a "www." in a while, might be cleaner to just show thesuperhackers.org.

www. removed.

Maybe also add a Super Hacker Unit soundbite (either random or preselected). Which could dictate the length how long the text is shown on screen. Just for the fact that C&C games do not have dead air.

There is

AudioEvent SuperHackerVoiceCreate
  Sounds = ihassea
  Control = RANDOM
  Priority = HIGH
  Volume = 110.0%
  MinVolume = 100.0%
  Type = WORLD GLOBAL PLAYER
End

I tried triggering it but that did not work, probably because it is a positional sound. Would require more effort to get working.

Maybe consider changing "Game improved by" to something like "Kept alive with love by" or "Lovingly maintained by".

I expect that many players could perceive this as "gay wording", because "lovingly" does not fit the theme of the game.

githubawn · 2026-06-01T21:51:24Z

It looks even stranger now.

…movie code (#2267)

…e (#2267)

…#2267)

xezon · 2026-07-10T20:49:43Z

Rebased on main.

ASCII symbols removed. Normal text readded. Author in UPPER CASE. Web url removed for simplicity.

Looks clean.

…#2267)

bobtista · 2026-07-12T12:30:48Z

+			, sizeY(10)
+			, centerOffsetY(0)
+		{}
+		~DisplayEntity();


DisplayEntity frees displayString in its destructor but has implicit copy ctor/assignment and lives in a std::vector, maybe free the strings in a ~Intro loop instead? I think this would only be an issue if someone appends a second credits screen though

Yes that is not so elegant. It would be solved by making the raw pointer a unique_ptr with c++11. I added a comment for now.

bobtista · 2026-07-12T12:37:03Z

Looks beautiful! I found that it crashes if I exit/alt f4 during our credit screen, left a couple of comments.

…#2267)

… (#2267)

xezon added Art Is art related Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Refactor Edits the code with insignificant behavior changes, is never user facing labels Feb 7, 2026

greptile-apps Bot reviewed Feb 7, 2026

View reviewed changes

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp

Comment thread Core/GameEngine/Include/GameClient/Intro.h

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp

xezon force-pushed the xezon/add-new-intro branch from 999721b to 0f278e6 Compare February 7, 2026 14:15

tintinhamans reviewed Feb 7, 2026

View reviewed changes

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp Outdated

xezon force-pushed the xezon/add-new-intro branch from 0f278e6 to 1a738f7 Compare February 7, 2026 16:19

greptile-apps Bot reviewed Feb 7, 2026

View reviewed changes

Comment thread Core/GameEngine/Include/GameClient/Intro.h

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp

xezon force-pushed the xezon/add-new-intro branch from 1a738f7 to 29b1ce7 Compare February 11, 2026 19:46

greptile-apps Bot reviewed Feb 11, 2026

View reviewed changes

xezon force-pushed the xezon/add-new-intro branch from 29b1ce7 to 9c82551 Compare February 11, 2026 19:55

xezon requested a review from tintinhamans February 11, 2026 19:58

greptile-apps Bot reviewed Feb 11, 2026

View reviewed changes

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp Outdated

bobtista reviewed May 26, 2026

View reviewed changes

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp Outdated

bobtista reviewed May 26, 2026

View reviewed changes

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp Outdated

bobtista reviewed May 26, 2026

View reviewed changes

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp

xezon force-pushed the xezon/add-new-intro branch from bf25fd5 to 2679b54 Compare May 31, 2026 10:29

xezon requested a review from bobtista May 31, 2026 16:21

xezon added 7 commits July 10, 2026 22:16

refactor(intro): Move intro related code to new file and class (#2267)

e3e8c9c

refactor(intro): Simplify the intro state machine in Intro class (#2267)

27cdb47

fix(intro): Remove non functional copyright string and simplify logo …

0e71109

…movie code (#2267)

tweak(intro): Remove superfluous legal page window from intro sequenc…

33f47d4

…e (#2267)

feat(intro): Add short Intro Logo for The Super Hackers team (#2267)

89c8906

fixup! feat(intro): Add short Intro Logo for The Super Hackers team (…

6d31c63

…#2267)

fixup! feat(intro): Add short Intro Logo for The Super Hackers team (…

60208cc

…#2267)

xezon force-pushed the xezon/add-new-intro branch from 2679b54 to 7702190 Compare July 10, 2026 20:48

greptile-apps Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread Core/GameEngine/Source/GameClient/Intro.cpp Outdated

fixup! feat(intro): Add short Intro Logo for The Super Hackers team (…

5e10a09

…#2267)

xezon force-pushed the xezon/add-new-intro branch from 7702190 to 5e10a09 Compare July 10, 2026 20:52

bobtista reviewed Jul 12, 2026

View reviewed changes

Comment thread GeneralsMD/Code/GameEngine/Source/GameClient/GameClient.cpp Outdated

bobtista reviewed Jul 12, 2026

View reviewed changes

xezon added 2 commits July 12, 2026 16:59

fixup! feat(intro): Add short Intro Logo for The Super Hackers team (…

eade693

…#2267)

fixup! refactor(intro): Move intro related code to new file and class…

ceb12df

… (#2267)

Uh oh!

Conversation

xezon commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Old Intro Sequence

New Intro Sequence

TODO

Uh oh!

greptile-apps Bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Feb 7, 2026

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

helmutbuhler commented Feb 7, 2026

Uh oh!

xezon commented Feb 7, 2026

Uh oh!

helmutbuhler commented Feb 7, 2026

Uh oh!

Caball009 commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LegionnaireG commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tintinhamans commented Feb 8, 2026

Uh oh!

xezon commented Feb 8, 2026

Uh oh!

xezon commented Feb 9, 2026

Uh oh!

xezon commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Feb 11, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xezon commented Feb 11, 2026

Uh oh!

fbraz3 commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xezon commented May 22, 2026

Uh oh!

githubawn commented May 26, 2026

Uh oh!

bobtista May 26, 2026

Choose a reason for hiding this comment

Uh oh!

xezon May 31, 2026

Choose a reason for hiding this comment

Uh oh!

xezon commented May 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bobtista commented May 26, 2026

Uh oh!

xezon commented Feb 7, 2026 •

edited

Loading

greptile-apps Bot commented Feb 7, 2026 •

edited

Loading

Caball009 commented Feb 8, 2026 •

edited

Loading

LegionnaireG commented Feb 8, 2026 •

edited

Loading

xezon commented Feb 11, 2026 •

edited

Loading

fbraz3 commented Feb 13, 2026 •

edited

Loading